| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Thom Brown <thom(at)linux(dot)com>, Fabrízio Mello <fabriziomello(at)gmail(dot)com>, Christoph Berg <cb(at)df7cb(dot)de>, Andres Freund <andres(at)2ndquadrant(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net> |
| Subject: | Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED |
| Date: | 2014-08-21 21:16:48 |
| Message-ID: | 9889.1408655808@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Agreed. I am going over this patch, and the last bit I need to sort out
> is the wording of these messages. I have temporarily settled on this:
> ereport(ERROR,
> (errcode(ERRCODE_INVALID_TABLE_DEFINITION),
> errmsg("cannot change logged status of table %s to logged",
> RelationGetRelationName(rel)),
> errdetail("Table %s references unlogged table %s.",
> RelationGetRelationName(rel),
> RelationGetRelationName(relfk))));
> Note the term "logged status" to talk about whether a table is logged or
> not. I thought about "loggedness" but I'm not sure english speakers are
> going to love me for that. Any other ideas there?
Just say "cannot change status of table %s to logged".
> Yeah, there is precedent for silently doing nothing. We previously
> threw warnings or notices, but nowadays even that is gone. Throwing an
> error definitely seems the wrong thing.
Agreed, just do nothing if it's already the right setting.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-08-21 21:17:30 | Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED |
| Previous Message | Tom Lane | 2014-08-21 21:13:33 | Re: WIP Patch for GROUPING SETS phase 1 |