Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED

On 2014-08-21 16:59:17 -0400, Alvaro Herrera wrote:
> Heikki Linnakangas wrote:
>
> > In Postgres internals slang, non-permanent means temporary or
> > unlogged. But I agree we shouldn't expose users to that term; we use
> > it in the docs, and it's not used in command names either.
>
> Agreed. I am going over this patch, and the last bit I need to sort out
> is the wording of these messages. I have temporarily settled on this:
>
> ereport(ERROR,
> (errcode(ERRCODE_INVALID_TABLE_DEFINITION),
> errmsg("cannot change logged status of table %s to logged",
> RelationGetRelationName(rel)),
> errdetail("Table %s references unlogged table %s.",
> RelationGetRelationName(rel),
> RelationGetRelationName(relfk))));

Maybe 'cannot change persistency of table .. from unlogged to logged'; possibly with
s/persistency/durability/?

Have you looked at the correctness of the patch itself? Last time I'd
looked it has fundamental correctness issues. I'd outlined a possible
solution, but I haven't looked since.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services