Re: narwhal and PGDLLIMPORT

Craig Ringer <craig(at)2ndquadrant(dot)com> writes:
> On 02/11/2014 01:28 PM, Tom Lane wrote:
>> If there are no objections, I'll push this patch into HEAD tomorrow,
>> along with the upthread patches from Craig Ringer and Marco Atzeri.
>> We might as well see if this stuff is going to work ...

> I'd love to test my patch properly before pushing it, but my dev machine
> is going to need a total teardown and rebuild, and I'm currently focused
> on polishing off urgent open work.

> So let's see what the buildfarm makes of it, I guess.

So the early returns from currawong are interesting:

"d:\bf\root\HEAD\pgsql.920\pgsql.sln" (default target) (1) ->
(contrib\pg_buffercache target) ->
pg_buffercache_pages.obj : error LNK2001: unresolved external symbol _MainLWLockArray
.\Release\pg_buffercache\pg_buffercache.dll : fatal error LNK1120: 1 unresolved externals

"d:\bf\root\HEAD\pgsql.920\pgsql.sln" (default target) (1) ->
(contrib\pg_stat_statements target) ->
pg_stat_statements.obj : error LNK2001: unresolved external symbol _MainLWLockArray
.\Release\pg_stat_statements\pg_stat_statements.dll : fatal error LNK1120: 1 unresolved externals

"d:\bf\root\HEAD\pgsql.920\pgsql.sln" (default target) (1) ->
(contrib\test_shm_mq target) ->
worker.obj : error LNK2001: unresolved external symbol _ProcDiePending
worker.obj : error LNK2001: unresolved external symbol _proc_exit_inprogress
.\Release\test_shm_mq\test_shm_mq.dll : fatal error LNK1120: 2 unresolved externals

I guess this is good news in one sense: now we're getting results from an
MSVC machine that are consistent with what narwhal has been telling us.
But how is it that your patch caused this to be reported when it wasn't
before? And how come we're not getting the results we hoped for, that
these symbols would be effectively exported without needing PGDLLIMPORT?

regards, tom lane