Re: jsonb status - ‘JsonbValue’ has no member named ‘size’

From: "Erik Rijkers" <er(at)xs4all(dot)nl>
To: "Peter Geoghegan" <pg(at)heroku(dot)com>
Cc: "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: jsonb status - ‘JsonbValue’ has no member named ‘size’
Date: 2014-03-16 11:37:02
Message-ID: 92d4fda05b98370724d9f0440ab61699.squirrel@webmail.xs4all.nl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, March 16, 2014 09:50, Peter Geoghegan wrote:
> On Sun, Mar 16, 2014 at 1:28 AM, Erik Rijkers <er(at)xs4all(dot)nl> wrote:
>>> [ jsonb-11.patch.gz ]
>>
>> This doesn't quite compile:
>
> Sorry. I guess Andrew's earlier merging of master was insufficient.
>
> Attached revision fixes bitrot.
>

Patch applies, but there is still something wrong; now during the actual compile (of contrib):
(this is actually the same error I get when pulling straight from the git repo (since yesterday somewhere, I think, or
maybe a bit earlier still))

(git repo being: on https://github.com/feodor/postgres.git, branch jsonb_and_hstore)

-- [2014.03.16 12:29:27 jsonb/0] make contrib
hstore_io.c: In function ‘hstore_to_jsonb’:
hstore_io.c:1398:6: error: ‘JsonbValue’ has no member named ‘size’
key.size = sizeof(JEntry);
^
hstore_io.c:1402:6: error: ‘JsonbValue’ has no member named ‘size’
key.size += key.string.len;
^
hstore_io.c:1408:7: error: ‘JsonbValue’ has no member named ‘size’
val.size = sizeof(JEntry);
^
hstore_io.c:1413:7: error: ‘JsonbValue’ has no member named ‘size’
val.size = sizeof(JEntry);
^
hstore_io.c:1417:7: error: ‘JsonbValue’ has no member named ‘size’
val.size += val.string.len;
^
hstore_io.c: In function ‘hstore_to_jsonb_loose’:
hstore_io.c:1450:6: error: ‘JsonbValue’ has no member named ‘size’
key.size = sizeof(JEntry);
^
hstore_io.c:1454:6: error: ‘JsonbValue’ has no member named ‘size’
key.size += key.string.len;
^
hstore_io.c:1458:6: error: ‘JsonbValue’ has no member named ‘size’
val.size = sizeof(JEntry);
^
hstore_io.c:1524:8: error: ‘JsonbValue’ has no member named ‘size’
val.size += VARSIZE_ANY(val.numeric) +sizeof(JEntry);
^
hstore_io.c:1528:8: error: ‘JsonbValue’ has no member named ‘size’
val.size = sizeof(JEntry);
^
hstore_io.c:1532:8: error: ‘JsonbValue’ has no member named ‘size’
val.size += val.string.len;
^
make[1]: *** [hstore_io.o] Error 1
make: *** [all-hstore-recurse] Error 2
-- make returned 2 - abort

thanks,

Erik Rijkers

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2014-03-16 11:58:53 AUTOCOMMIT off + ON_ERROR_ROLLBACK usability
Previous Message Amit Kapila 2014-03-16 11:21:18 Re: [RFC] What should we do for reliable WAL archiving?