Re: jsonb status - 'JsonbValue' has no member named 'size'

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Erik Rijkers <er(at)xs4all(dot)nl>
Cc: Peter Geoghegan <pg(at)heroku(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: jsonb status - 'JsonbValue' has no member named 'size'
Date: 2014-03-16 12:23:40
Message-ID: 532597CC.2020603@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 03/16/2014 07:37 AM, Erik Rijkers wrote:
> On Sun, March 16, 2014 09:50, Peter Geoghegan wrote:
>> On Sun, Mar 16, 2014 at 1:28 AM, Erik Rijkers <er(at)xs4all(dot)nl> wrote:
>>>> [ jsonb-11.patch.gz ]
>>> This doesn't quite compile:
>> Sorry. I guess Andrew's earlier merging of master was insufficient.
>>
>> Attached revision fixes bitrot.
>>
> Patch applies, but there is still something wrong; now during the actual compile (of contrib):
> (this is actually the same error I get when pulling straight from the git repo (since yesterday somewhere, I think, or
> maybe a bit earlier still))
>
> (git repo being: on https://github.com/feodor/postgres.git, branch jsonb_and_hstore)
>
>
>
> -- [2014.03.16 12:29:27 jsonb/0] make contrib
> hstore_io.c: In function ‘hstore_to_jsonb’:
> hstore_io.c:1398:6: error: ‘JsonbValue’ has no member named ‘size’
> key.size = sizeof(JEntry);

Yeah, the field name was changed but this wasn't followed through to
contrib.

New patch attached.

cheers

andrew

Attachment Content-Type Size
jsonb-12.patch text/x-patch 423.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2014-03-16 12:31:53 Re: [bug fix] PostgreSQL fails to start on Windows if it crashes after tablespace creation
Previous Message Joshua Yanovski 2014-03-16 12:08:01 [WIP] Better partial index-only scans