Re: shmem startup and shutdown hooks

From: Amit kapila <amit(dot)kapila(at)huawei(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: shmem startup and shutdown hooks
Date: 2013-05-26 06:22:51
Message-ID: 6C0B27F7206C9E4CA54AE035729E9C38421B25B3@szxeml558-mbs.china.huawei.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On Saturday, May 25, 2013 12:50 AM Alvaro Herrera wrote:

> Hi,

> While going through Andres' BDR code I noticed that it has a shmem
> startup hook, which installs a on_shmem_exit() callback to write stuff
> at shutdown time. This works fine but seems somewhat of a hazard: it is
> having postmaster do the actual write, which has to access shared memory
> while doing it. Moreover, since the callback is installed to be called
> at shmem reset, it means that a process crash causes this code to be
> called, which seems similarly broken.

> It seems that the right place to do this is checkpointer shutdown, i.e.
> when checkpointer is told to close shop it should also invoke various
> modules' shutdown callbacks. There's no hook point there though, so
> we'd need to introduce something new for this specific purpose.

Do you mean to say that during shutdown of checkpoint, it should call interface which does same
as shmem_exit() which means call shutdown callbacks of other modules?
Why would checkpointer shutdown is better place to handle?

With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2013-05-26 08:31:56 COPY .... (FORMAT binary) syntax doesn't work
Previous Message Christoph Berg 2013-05-26 05:29:37 Re: PostgreSQL 9.3 beta breaks some extensions "make install"