Re: Block-level CRC checks

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, decibel <decibel(at)decibel(dot)org>, "Jonah H(dot) Harris" <jonah(dot)harris(at)gmail(dot)com>, jd(at)commandprompt(dot)com, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Aidan Van Dyk <aidan(at)highrise(dot)ca>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Block-level CRC checks
Date: 2009-12-04 15:00:00
Message-ID: 603c8f070912040700l3666cbf8n25b4ba6fbbeb1e3b@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Dec 4, 2009 at 9:48 AM, Alvaro Herrera
<alvherre(at)commandprompt(dot)com> wrote:
> Heikki Linnakangas escribió:
>> Simon Riggs wrote:
>> > On Fri, 2009-12-04 at 09:52 -0300, Alvaro Herrera wrote:
>> >
>> >> BTW with VACUUM FULL removed I assume we're going to get rid of
>> >> HEAP_MOVED_IN and HEAP_MOVED_OFF too, right?
>> >
>> > Much as I would like to see those go, no. VF code should remain for some
>> > time yet, IMHO.
>>
>> I don't think we need to keep VF code otherwise, but I would leave
>> HEAP_MOVED_IN/OFF support alone for now for in-place upgrade. Otherwise
>> we need a pre-upgrade script or something to scrub them off.
>
> CRCs are going to need scrubbing anyway, no?  Oh, but you're assuming
> that CRCs are optional, so not everybody would need that, right?

If we can make not only the validity but also the presence of the CRC
field optional, it will simplify things greatly for in-place upgrade,
I think, because the upgrade won't itself require expanding the page.
Turning on the CRC functionality for a particular table may require
expanding the page, but that's a different problem. :-)

Have we thought about what other things have changed between 8.4 and
8.5 that might cause problems for in-place upgrade?

...Robert

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff 2009-12-04 15:19:53 Re: First feature patch for plperl - draft [PATCH]
Previous Message Alvaro Herrera 2009-12-04 14:48:30 Re: Block-level CRC checks