Re: Bugfix and new feature for PGXS

On 12/04/2014 03:47 PM, Andrew Dunstan wrote:
>
> On 12/04/2014 02:44 PM, Peter Eisentraut wrote:
>> On 12/4/14 11:38 AM, Peter Eisentraut wrote:
>>> On 11/19/14 11:11 PM, Peter Eisentraut wrote:
>>>> I noticed this item was still in the 9.4 code. Looking at the
>>>> original
>>>> submission
>>>> (http://www.postgresql.org/message-id/201306181552.36673.cedric@2ndquadrant.com,
>>>>
>>>> patch 0001), I think the original reason for adding this was wrong to
>>>> begin with.
>>> I have applied all three patches to 9.4 and 9.5. So this issue is now
>>> resolved.
>> Apparently, some buildfarm module is unhappy with this:
>>
>> http://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=sittella&dt=2014-12-04%2017%3A16%3A29&stg=RedisFDW-build
>>
>>
>> Is there some custom code running there? I don't know how that error
>> would happen otherwise?
>>
>>
>
>
> You have broken two buildfarm instances that build and test external
> modules - in one case the Redis FDW module and in the other the File
> Text Array FDW. I will see what can be retrieved.
>
>

I think this needs to be reverted. This has broken two modules that are
not even using vpath builds.

You can see the relevant Makefiles at:
<https://github.com/adunstan/file_text_array_fdw/blob/master/Makefile>
and <https://github.com/pg-redis-fdw/redis_fdw/blob/master/Makefile>.

IIRC, the code you found convoluted and removed was required precisely
to prevent this sort of error.

cheers

andrew