Re: [BUGS] BUG #12070: hstore extension: hstore_to_json_loose produces invalid JSON

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: bouda(at)edookit(dot)com, pgsql-bugs(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [BUGS] BUG #12070: hstore extension: hstore_to_json_loose produces invalid JSON
Date: 2014-11-30 21:48:14
Message-ID: 547B909E.4010801@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers


On 11/30/2014 04:31 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> OK, here's the patch.
> Can we make IsValidJsonNumber() take a "const char *"? Also its
> comment should specify that it doesn't require nul-terminated
> input, if indeed it doesn't. Otherwise +1.
>
>

Then I have to cast away the const-ness when I assign it inside the
function. Constifying the whole API would be a rather larger project, I
suspect, assuming it's possible.

cheers

andrew

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Ondřej Bouda 2014-11-30 21:55:28 Re: BUG #12106: pg_dump does not resolve circular dependency
Previous Message Tom Lane 2014-11-30 21:31:40 Re: [HACKERS] BUG #12070: hstore extension: hstore_to_json_loose produces invalid JSON

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Berry 2014-11-30 22:49:45 BDR Consistency in Insert/Update pkey conflicts
Previous Message Tom Lane 2014-11-30 21:31:40 Re: [HACKERS] BUG #12070: hstore extension: hstore_to_json_loose produces invalid JSON