Re: [HACKERS] BUG #12070: hstore extension: hstore_to_json_loose produces invalid JSON

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: bouda(at)edookit(dot)com, pgsql-bugs(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] BUG #12070: hstore extension: hstore_to_json_loose produces invalid JSON
Date: 2014-11-30 21:31:40
Message-ID: 29018.1417383100@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> OK, here's the patch.

Can we make IsValidJsonNumber() take a "const char *"? Also its
comment should specify that it doesn't require nul-terminated
input, if indeed it doesn't. Otherwise +1.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Andrew Dunstan 2014-11-30 21:48:14 Re: [BUGS] BUG #12070: hstore extension: hstore_to_json_loose produces invalid JSON
Previous Message Andrew Dunstan 2014-11-30 20:37:35 Re: [HACKERS] BUG #12070: hstore extension: hstore_to_json_loose produces invalid JSON

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2014-11-30 21:48:14 Re: [BUGS] BUG #12070: hstore extension: hstore_to_json_loose produces invalid JSON
Previous Message Andrew Dunstan 2014-11-30 20:37:35 Re: [HACKERS] BUG #12070: hstore extension: hstore_to_json_loose produces invalid JSON