Re: Turning recovery.conf into GUCs

From: Josh Berkus <josh(at)agliodbs(dot)com>
To: Alex Shulgin <ash(at)commandprompt(dot)com>
Cc: Jaime Casanova <jaime(at)2ndquadrant(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Turning recovery.conf into GUCs
Date: 2014-11-24 22:14:56
Message-ID: 5473ADE0.6090300@agliodbs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11/24/2014 02:00 PM, Alex Shulgin wrote:
>
> Josh Berkus <josh(at)agliodbs(dot)com> writes:
>>>
>>> only that you need to start in recovery mode to start replication
>>
>> Right, but my point is that having a trigger file *is not necessary for
>> replication, only for PITR* -- and maybe not necessary even for PITR.
>> That is, in a streaming replication configuration, having a
>> "standby_mode = on|off" parameter is 100% sufficient to control
>> replication with the small detail that "pg_ctl promote" needs to set it
>> in pg.auto.conf or conf.d.
>>
>> And, now, having given it some thought, I'm going to argue that it's not
>> required for PITR either, provided that we can use the auto.conf method.
>>
>> Before I go into my ideas, though, what does the current patch do
>> regarding non-replication PITR?
>
> It removes that $PGDATA/standby.enable trigger file it relies on to
> start the PITR in the first place.

OK, and that's required for replication too? I'm OK with that if it
gets the patch in.

--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alex Shulgin 2014-11-24 22:18:30 Re: Turning recovery.conf into GUCs
Previous Message Andres Freund 2014-11-24 22:12:09 Re: Turning recovery.conf into GUCs