| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: WAL format and API changes (9.5) |
| Date: | 2014-11-21 10:16:38 |
| Message-ID: | 546F1106.60802@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/21/2014 09:19 AM, Michael Paquier wrote:
> On Fri, Nov 21, 2014 at 2:06 AM, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com
>> wrote:
>
>> As you may have noticed, I committed this (after some more cleanup). Of
>> course, feel free to still review it, and please point out any issues you
>> may find.
>>
>
> This comment on top of XLogRecordAssemble is not adapted as
> page_writes_omitted does not exist. Perhaps this is a remnant of some older
> version of the patch?
> * If there are any registered buffers, and a full-page image was not taken
> * of all them, *page_writes_omitted is set to true. This signals that the
> * assembled record is only good for insertion on the assumption that the
> * RedoRecPtr and doPageWrites values were up-to-date.
> */
Yep, fixed thanks.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2014-11-21 11:01:50 | Re: What exactly is our CRC algorithm? |
| Previous Message | Abhijit Menon-Sen | 2014-11-21 10:11:45 | Re: What exactly is our CRC algorithm? |