| From: | Jan Wieck <jan(at)wi3ck(dot)info> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, furuyao(at)pm(dot)nttdata(dot)co(dot)jp, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_receivexlog and replication slots |
| Date: | 2014-10-01 17:22:53 |
| Message-ID: | 542C386D.4040609@wi3ck.info |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/01/2014 01:19 PM, Andres Freund wrote:
> On 2014-10-01 13:17:17 -0400, Jan Wieck wrote:
>> >>-static void StreamLog();
>> >>+static void StreamLogicalLog();
>> >>Not related at all to those patches, but for correctness it is better to
>> >>add a declaration "(void)".
>> >
>> >Agreed.
>> >
>> >>Except those small things the changes look good to me.
>> >
>> >Cool. Will push and then, sometime this week, review the next patch.
>
>> You might want to do that function renaming in pg_receivexlog.c as well.
>
> Why? You mean to StreamPhysicalLog()?
>
> Greetings,
>
> Andres Freund
>
Like that.
Plus, there is one more occurrence of StreamLog() in pg_recvlogical.c.
Jan
--
Jan Wieck
Senior Software Engineer
http://slony.info
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-10-01 17:32:16 | Re: pg_receivexlog and replication slots |
| Previous Message | Andres Freund | 2014-10-01 17:19:17 | Re: pg_receivexlog and replication slots |