| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Jan Wieck <jan(at)wi3ck(dot)info> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, furuyao(at)pm(dot)nttdata(dot)co(dot)jp, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_receivexlog and replication slots |
| Date: | 2014-10-01 17:19:17 |
| Message-ID: | 20141001171917.GA7812@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-10-01 13:17:17 -0400, Jan Wieck wrote:
> >>-static void StreamLog();
> >>+static void StreamLogicalLog();
> >>Not related at all to those patches, but for correctness it is better to
> >>add a declaration "(void)".
> >
> >Agreed.
> >
> >>Except those small things the changes look good to me.
> >
> >Cool. Will push and then, sometime this week, review the next patch.
> You might want to do that function renaming in pg_receivexlog.c as well.
Why? You mean to StreamPhysicalLog()?
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jan Wieck | 2014-10-01 17:22:53 | Re: pg_receivexlog and replication slots |
| Previous Message | Jan Wieck | 2014-10-01 17:17:17 | Re: pg_receivexlog and replication slots |