Re: Inefficient barriers on solaris with sun cc

From: Oskari Saarenmaa <os(at)ohmu(dot)fi>
To: Andres Freund <andres(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Inefficient barriers on solaris with sun cc
Date: 2014-09-26 12:36:02
Message-ID: 54255DB2.6070106@ohmu.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

25.09.2014, 16:34, Andres Freund kirjoitti:
> Binaries compiled on solaris using sun studio cc currently don't have
> compiler and memory barriers implemented. That means we fall back to
> relatively slow generic implementations for those. Especially compiler,
> read, write barriers will be much slower than necessary (since they all
> just need to prevent compiler reordering as both sparc and x86 are run
> in TSO mode under solaris).

Attached patch implements compiler and memory barriers for Solaris
Studio based on documentation at
http://docs.oracle.com/cd/E18659_01/html/821-1383/gjzmf.html

I defined read and write barriers as acquire and release barriers
instead of pure read and write ones as that's what other platforms
appear to do.

/ Oskari

Attachment Content-Type Size
0001-atomics-add-compiler-and-memory-barriers-for-solaris.patch text/x-patch 3.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2014-09-26 12:39:38 Re: Inefficient barriers on solaris with sun cc
Previous Message Heikki Linnakangas 2014-09-26 12:32:35 Re: INSERT ... ON CONFLICT {UPDATE | IGNORE}