Re: [PATCH] Fix search_path default value separator.

On 08/15/2014 04:58 PM, Bruce Momjian wrote:
> On Fri, Aug 15, 2014 at 10:40:59PM +0900, Fujii Masao wrote:
>>>> Heh. I'm not particularly averse to changing this, but I guess I
>>>> don't see any particular benefit of changing it either. Either comma
>>>> or comma-space is a legal separator, so why worry about it?
>>
>> This change might cause me to update the existing documents (which
>> I need to maintain in my company) including the output example of
>> default search_path. If the change is for the improvement, I'd be
>> happy to do that, but it seems not.
>>
>> Also there might be some PostgreSQL extensions which their regression test
>> shows the default search_path. This patch would make their developers
>> spend the time to update the test. I'm sure that they are fine with that if
>> it's for an improvement. But not.
>
> Well, rename GUC often too for clearity, so I don't see adjusting
> white-space as something to avoid either. It is always about short-term
> adjustments vs. long-term clarity.

I think this is an improvement, although a really minor one. Although
Robert & Fujii questioned if this is worth it, I didn't hear anyone
objecting strongly, so committed.

- Heikki