Re: [PATCH] Fix search_path default value separator.

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Christoph Martin <christoph(dot)r(dot)martin(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Fix search_path default value separator.
Date: 2014-08-15 13:58:33
Message-ID: 20140815135833.GA26082@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Aug 15, 2014 at 10:40:59PM +0900, Fujii Masao wrote:
> >> Heh. I'm not particularly averse to changing this, but I guess I
> >> don't see any particular benefit of changing it either. Either comma
> >> or comma-space is a legal separator, so why worry about it?
>
> This change might cause me to update the existing documents (which
> I need to maintain in my company) including the output example of
> default search_path. If the change is for the improvement, I'd be
> happy to do that, but it seems not.
>
> Also there might be some PostgreSQL extensions which their regression test
> shows the default search_path. This patch would make their developers
> spend the time to update the test. I'm sure that they are fine with that if
> it's for an improvement. But not.

Well, rename GUC often too for clearity, so I don't see adjusting
white-space as something to avoid either. It is always about short-term
adjustments vs. long-term clarity.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-08-15 13:59:28 Re: Reporting the commit LSN at commit time
Previous Message Tom Lane 2014-08-15 13:57:04 Re: ALTER TABLESPACE MOVE command tag tweak