Re: Review: ECPG FETCH readahead

From: Boszormenyi Zoltan <zboszor(at)pr(dot)hu>
To: Antonin Houska <antonin(dot)houska(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Meskes <meskes(at)postgresql(dot)org>, Noah Misch <noah(at)leadboat(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Hans-Jürgen Schönig <hs(at)cybertec(dot)at>
Subject: Re: Review: ECPG FETCH readahead
Date: 2014-04-24 13:19:48
Message-ID: 53590F74.7040301@pr.hu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2014-04-24 14:50 keltezéssel, Michael Meskes írta:
> Thanks an awful lot Antonin.
>
>> Committer availability might well be the issue, but missing review
>> probably too.
> Yes, you're right. If my taks is mostly one last glance and a commit I will make time for that.
>
>> Whether this review is enough to move the patch to "ready for committer"
>> - I tend to let the next CFM decide. (I don't find it productive to
>> ignite another round of discussion about kinds of reviews - already saw
>> some.)
> I saw some remarks in your review that Zoltan wants to address. Once I got the
> updated version I'll have a look at it.
>
> Zoltan, could you send a new version by end of day tomorrow? I'll be sitting on
> a plane for a longer time again on Saturday. :)

I will try to.

Thanks in advance,
Zoltán

>
> Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marti Raudsepp 2014-04-24 13:40:08 Re: 9.4 Proposal: Initdb creates a single table
Previous Message Andres Freund 2014-04-24 13:05:18 Re: slow startup due to LWLockAssign() spinlock