| From: | Jan Wieck <jan(at)wi3ck(dot)info> |
|---|---|
| To: | Marko Kreen <markokr(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Problem with txid_snapshot_in/out() functionality |
| Date: | 2014-04-13 21:46:20 |
| Message-ID: | 534B05AC.9010602@wi3ck.info |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 04/13/14 14:22, Jan Wieck wrote:
> On 04/13/14 08:27, Marko Kreen wrote:
>> I think you need to do SET_VARSIZE also here. Alternative is to
>> move SET_VARSIZE after sort_snapshot().
>>
>> And it seems the drop-double-txid logic should be added also to
>> txid_snapshot_recv(). It seems weird to have it behave differently
>> from txid_snapshot_in().
>>
>
> Thanks,
>
> yes on both issues. Will create another patch.
New patch attached.
New github commit is
https://github.com/wieck/postgres/commit/b8fd0d2eb78791e5171e34aecd233fd06218890d
Thanks again,
Jan
--
Jan Wieck
Senior Software Engineer
http://slony.info
| Attachment | Content-Type | Size |
|---|---|---|
| txid_snapshot_filter_duplicate_xip_v2.diff | text/plain | 5.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2014-04-14 00:41:15 | Re: pgsql: Add ANALYZE into regression tests |
| Previous Message | John Mudd | 2014-04-13 21:00:32 | Fwd: [HACKERS] Fwd: Debug strategy for musl Postgres? |