| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Payal Singh <payal(at)omniti(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Review: Patch FORCE_NULL option for copy COPY in CSV mode |
| Date: | 2014-03-05 14:27:56 |
| Message-ID: | 5317346C.9000501@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03/05/2014 09:11 AM, Michael Paquier wrote:
> After testing this feature, I noticed that FORCE_NULL and
> FORCE_NOT_NULL can both be specified with COPY on the same column.
> This does not seem correct. The attached patch adds some more error
> handling, and a regression test case for that.
>
Strictly they are not actually contradictory, since FORCE NULL relates
to quoted null strings and FORCE NOT NULL relates to unquoted null
strings. Arguably the docs are slightly loose on this point. Still,
applying both FORCE NULL and FORCE NOT NULL to the same column would be
rather perverse, since it would result in a quoted null string becoming
null and an unquoted null string becoming not null.
I'd be more inclined just to tighten the docs and maybe expand the
regression tests a bit, but I could be persuaded the other way if people
think it's worth it.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Florian Pflug | 2014-03-05 14:35:53 | Re: [PATCH] Negative Transition Aggregate Functions (WIP) |
| Previous Message | Michael Paquier | 2014-03-05 14:11:41 | Re: Review: Patch FORCE_NULL option for copy COPY in CSV mode |