Re: Review: Patch FORCE_NULL option for copy COPY in CSV mode

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Payal Singh <payal(at)omniti(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Review: Patch FORCE_NULL option for copy COPY in CSV mode
Date: 2014-03-05 15:09:48
Message-ID: 3732.1394032188@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 03/05/2014 09:11 AM, Michael Paquier wrote:
>> After testing this feature, I noticed that FORCE_NULL and
>> FORCE_NOT_NULL can both be specified with COPY on the same column.

> Strictly they are not actually contradictory, since FORCE NULL relates
> to quoted null strings and FORCE NOT NULL relates to unquoted null
> strings. Arguably the docs are slightly loose on this point. Still,
> applying both FORCE NULL and FORCE NOT NULL to the same column would be
> rather perverse, since it would result in a quoted null string becoming
> null and an unquoted null string becoming not null.

Given the remarkable lack of standardization of "CSV" output, who's
to say that there might not be data sources out there for which this
is the desired behavior? It's weird, I agree, but I think throwing
an error for the combination is not going to be helpful. It's not
like somebody might accidentally write both on the same column.

+1 for clarifying the docs, though, more or less in the words you
used above.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2014-03-05 15:19:33 Re: jsonb and nested hstore
Previous Message Pavel Stehule 2014-03-05 15:08:28 Re: Fwd: patch: make_timestamp function