Re: Recovery to backup point

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: MauMau <maumau307(at)gmail(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Recovery to backup point
Date: 2014-01-24 20:10:23
Message-ID: 52E2C8AF.9040006@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 01/24/2014 01:37 PM, MauMau wrote:
> Hi, Heiki-san,
>
> From: "MauMau" <maumau307(at)gmail(dot)com>
>> From: "Heikki Linnakangas" <hlinnakangas(at)vmware(dot)com>
>>> After some refactoring and fixing bugs in the existing code, I came up
>>> with the attached patch. I called the option simply "recovery_target",
>>> with the only allowed value of "immediate". IOW, if you want to stop
>>> recovery as early as possible, you add recovery_target='immediate' to
>>> recovery.conf. Now that we have four different options to set the
>>> recovery target with, I rearranged the docs slightly. How does this look
>>> to you?
>>
>> I'm almost comfortable with your patch. There are two comments:
>>
>> C1. The following parts seem to be mistakenly taken from my patch. These
>> are not necessary for your patch, aren't they?
>
> I'm going to add the attached new revision of the patch soon, which is
> almost based on yours. All what I modified is removal of parts I mentioned
> above. I confirmed that the original problem could be solved. Thanks.

Thanks, committed!

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Laurence Rowe 2014-01-24 20:40:06 Re: new json funcs
Previous Message Alvaro Herrera 2014-01-24 20:06:31 LIKE INCLUDING CONSTRAINTS is broken