Re: Eliminating pg_catalog.pg_rewrite.ev_attr

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Kevin Grittner <kgrittn(at)ymail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Eliminating pg_catalog.pg_rewrite.ev_attr
Date: 2013-09-04 16:39:12
Message-ID: 5293.1378312752@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Kevin Grittner <kgrittn(at)ymail(dot)com> writes:
> Unless someone has an objection or thinks this needs to go through
> the CF process, I will commit it tomorrow, with a catversion bump.

Shouldn't attribute_used() be removed from rewriteManip.h?

I was a bit surprised by your removal of the rangeTableEntry_used()
test in the hunk at rewriteHandler.c:1273ff. That's probably all
right, but it takes this out of the realm of a mechanical change.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2013-09-04 16:50:17 Re: [v9.4] row level security
Previous Message Atri Sharma 2013-09-04 16:31:51 Re: Re: Proposal/design feedback needed: WITHIN GROUP (sql standard ordered set aggregate functions)