| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Gurjeet Singh <gurjeet(at)singh(dot)im>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Shave a few instructions from child-process startup sequence |
| Date: | 2013-11-20 15:21:30 |
| Message-ID: | 528CD37A.4020206@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/5/13, 2:47 AM, Gurjeet Singh wrote:
> On Mon, Nov 4, 2013 at 12:20 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us
> <mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us>> wrote:
>
> But we're not buying much. A few instructions during postmaster
> shutdown
> is entirely negligible.
>
>
> The patch is for ClosePostmasterPorts(), which is called from every
> child process startup sequence (as $subject also implies), not in
> postmaster shutdown. I hope that adds some weight to the argument.
If there is a concern about future maintenance, you could add assertions
(in appropriate compile mode) that the rest of the array is indeed
PGINVALID_SOCKET. I think that could be a win for both performance and
maintainability.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2013-11-20 15:28:36 | Re: Autoconf 2.69 update |
| Previous Message | Bruce Momjian | 2013-11-20 15:16:00 | Re: Suggestion: Issue warning when calling SET TRANSACTION outside transaction block |