From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
---|---|
To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, David Fetter <david(at)fetter(dot)org>, Josh Kupershmidt <schmiddy(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net> |
Subject: | Re: pg_restore multiple --function options |
Date: | 2013-08-27 17:14:32 |
Message-ID: | 521CDE78.3050208@vmware.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 27.08.2013 03:26, Michael Paquier wrote:
> On Tue, Aug 27, 2013 at 5:17 AM, David Fetter<david(at)fetter(dot)org> wrote:
>> On Mon, Aug 26, 2013 at 10:29:06PM +0300, Heikki Linnakangas wrote:
>>> While looking at the pg_restore code, I noticed that while it
>>> supports specifying multiple --table options to restore several
>>> tables, it does not support multiple --function options. Or --index,
>>> --schema, or --trigger.
>>>
>>> The support for multiple --table options was added in 9.3, in
>>> January. See http://www.postgresql.org/message-id/CAK3UJRG+yV1mK5twLfKVMCwXH4f6PnJou6Rn=ecabyfQH1vVHg@mail.gmail.com.
>>> Was there a particular reason for only doing it for --table, or was
>>> it just an oversight or lack of interest? No doubt that --table is
>>> the most interesting one, but IMHO the other options should behave
>>> the same, for the sake of consistency.
>>
>> +1 for making them consistent. There will also be an improvement in
>> usability.
> +1. It would be good to have consistency there for all the objects.
Would anyone object to backpatching that change to 9.3 ? The risk seems
very small, and it would be good to do the other options in the same
release as --table. It was an oversight to only do it for --table in 9.3.
Assuming no objections, I'll apply the attached patch to 9.3 and master
later tonight.
- Heikki
Attachment | Content-Type | Size |
---|---|---|
multiple-pg_restore-options-1.patch | text/x-diff | 5.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2013-08-27 17:58:35 | Re: changeset generation v5-01 - Patches & git tree |
Previous Message | Alvaro Herrera | 2013-08-27 16:46:41 | Re: Detail part for still waiting for lock log message |