Re: Kudos for Reviewers -- wrapping it up

From: Josh Berkus <josh(at)agliodbs(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Kudos for Reviewers -- wrapping it up
Date: 2013-08-02 21:36:42
Message-ID: 51FC266A.6060808@agliodbs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 08/02/2013 02:24 PM, Bruce Momjian wrote:

> Based on existing workflow, we need those reviewer names in the commit
> message. I don't see how the CommitFestManager can help with that.

We can change the workflow. It's ours, there's no government agency
mandating it.

Anyway, the list from the CFM would just be to make sure nobody got
missed; it's a double-check on the commit messages.

>> The CFM needs to supply the list of "reviewers at the end" anyway.
>
> Why?

Who else would do it?

>> BTW, all of this I'm talking about the 9.4 release notes, where we have
>> the opportunity to start from the first CF. There's the question of what
>> to do about the *9.3* release notes, which I'll address in a seperate email.
>
> I am worried we are talking about 9.5 as we have already committed quite
> a bit to 9.4.

You're making a big deal out of what's a minor clerical detail. Don't
let minutia which any secretary could take care of get in the way of an
important project goal, that is, rewarding reviewers so that lack of
reviewers stops being a major project bottleneck.

--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2013-08-02 21:37:28 Re: 9.3 Reviewer Credit WAS: Kudos for Reviewers -- wrapping it up
Previous Message Alvaro Herrera 2013-08-02 21:25:53 Re: HeapTupleSatisfiesDirty fails to test HEAP_XMAX_IS_LOCKED_ONLY for TransactionIdIsInProgress(...)