| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Greg Smith <greg(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: auto-sizing wal_buffers |
| Date: | 2011-01-23 02:24:48 |
| Message-ID: | 508.1295749488@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> I'm going with hacks. Any API that requires you to print to a string
> so you can turn around and immediately convert it back to an integer
> is not too swift.
Oh, you're complaining about SetConfigOption, not the assign hooks.
Not sure if it's really worth refactoring that. The problem is that
there are lots and lots and lots of places that need to call that
*without* any dependency on what the datatype of the target GUC option
really is. There are a small number where we do know the type and
conversion to a string is just overhead. If any of those were
performance-critical it might be worth worrying about, but this one
certainly isn't.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-01-23 02:26:42 | Re: auto-sizing wal_buffers |
| Previous Message | Robert Haas | 2011-01-23 02:24:18 | Re: Transaction-scope advisory locks |