Re: PL/Perl Does not Like vstrings

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "David E(dot) Wheeler" <david(at)justatheory(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PL/Perl Does not Like vstrings
Date: 2012-01-05 18:13:45
Message-ID: 4F05E859.1000701@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 01/05/2012 01:09 PM, Tom Lane wrote:
> Andrew Dunstan<andrew(at)dunslane(dot)net> writes:
>> The fix that has been applied, as Tom suggested, is at the point where
>> we call SvPVutf8(), so that's not just for elog().
> That patch looks good, but do we want to look into the other point about
> error recovery? The real bottom line here is that when SvPVutf8 threw a
> croak(), we didn't recover sanely at all --- in fact, it was almost
> impossible to tell what had happened even in gdb, until I installed
> perl debugging symbols and single-stepped through things. I would have
> hoped that we'd at least see the croak message. This seems a bit
> nervous-making, as plperl sure calls a lot of stuff that in principle
> could croak.
>
>

Yes, I think so. That seemed like a separate issue, though, which is why
I just applied the workaround to the reported problem. I had similar
issues with gdb - it wasn't a pleasant experience.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2012-01-05 18:26:20 Re: CLOG contention
Previous Message Tom Lane 2012-01-05 18:09:14 Re: PL/Perl Does not Like vstrings