| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Small patch for GiST: move childoffnum to child |
| Date: | 2011-07-15 09:27:40 |
| Message-ID: | 4E20080C.7040806@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 13.07.2011 22:04, Heikki Linnakangas wrote:
> On 13.07.2011 21:56, Alexander Korotkov wrote:
>> Thank you very much for detail explanation. But this line of modified
>> patch
>> seems strange for me:
>> *newchildoffnum = blkno;
>> I believe it should be:
>> *newchildoffnum = i;
>
> Yes, you're right. It's scary that it worked during testing anyway.
> Maybe the resulting tree was indeed broken but it didn't affect the
> subsequent inserts so I didn't notice.
Ok, committed this now. I decided to rename the childoffnum field to
"downlinkoffnum". I figured it'd be dangerous that the field means
something subtly different in different versions, if we need to
backpatch bug fixes that use that field.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2011-07-15 10:01:16 | Re: Small patch for GiST: move childoffnum to child |
| Previous Message | Alexander Korotkov | 2011-07-15 09:09:42 | Re: Patch Review: Collect frequency statistics and selectivity estimation for arrays |