Re: Re: [COMMITTERS] pgsql: Don't use "cp -i" in the example WAL archive_command.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Thom Brown <thom(at)linux(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Don't use "cp -i" in the example WAL archive_command.
Date: 2011-06-18 13:39:32
Message-ID: 4DFCAA94.80409@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 06/18/2011 09:19 AM, Tom Lane wrote:
> Thom Brown<thom(at)linux(dot)com> writes:
>> On 18 June 2011 04:13, Bruce Momjian<bruce(at)momjian(dot)us> wrote:
>>> I tested on FreeBSD 7.4 and saw a 1 error return:
>> And on a Mac (so through Darwin 10.7.0 a BSD version too):
> Yeah, see yesterday's discussion on pgsql-admin. I think the behavior
> with the error return may be a BSD-ism. In any case, GNU cp does *not*
> do what we want, and that accounts for a sufficiently large fraction of
> machines in the field that I think it's just unsafe to suggest using
> "cp -i" so prominently. There are too many people who'll just copy and
> paste the first example provided, especially if the warning to test it
> is buried several paragraphs later.
>
>

Yeah, I'm glad to see this go anyway. I always thought the example was
too cute by half. Using an explicit test is much nicer and more obvious.

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2011-06-18 13:44:02 Re: Re: [COMMITTERS] pgsql: Don't use "cp -i" in the example WAL archive_command.
Previous Message Bruce Momjian 2011-06-18 13:28:48 Re: Re: [COMMITTERS] pgsql: Don't use "cp -i" in the example WAL archive_command.

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2011-06-18 13:44:02 Re: Re: [COMMITTERS] pgsql: Don't use "cp -i" in the example WAL archive_command.
Previous Message Noah Misch 2011-06-18 13:37:03 Re: crash-safe visibility map, take five