Re: [COMMITTERS] pgsql: Move test_fsync to /contrib.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Move test_fsync to /contrib.
Date: 2011-01-22 16:38:23
Message-ID: 4D3B07FF.3010309@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 01/21/2011 12:48 PM, Bruce Momjian wrote:
> Move test_fsync to /contrib.
>
>

This appears to have broken Solaris, Unixware and MSVC builds.

Here's the error on Solaris:

gmake[1]: Entering directory `/export/home/dpage/pgbuildfarm/moa/HEAD/pgsql.4167/contrib/pg_test_fsync'
cc -Xa -m64 -xarch=native -xdepend -xO3 -xprefetch=auto,explicit -g -I. -I. -I../../src/include -c -o pg_test_fsync.o pg_test_fsync.c
cc -Xa -m64 -xarch=native -xdepend -xO3 -xprefetch=auto,explicit -g pg_test_fsync.o -L../../src/port -Wl,-R'/export/home/dpage/pgbuildfarm/moa/HEAD/inst/lib' -lpgport -lpam -lgss -lz -lnsl -lsocket -lm -o pg_test_fsync
Undefined first referenced
symbol in file
CurrentMemoryContext pg_test_fsync.o
ld: fatal: Symbol referencing errors. No output written to pg_test_fsync

Why does pg_test_fsync.c include postgres.h? Shouldn't it use postgres_fe.h?

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2011-01-22 17:08:46 Re: [COMMITTERS] pgsql: Move test_fsync to /contrib.
Previous Message Robert Haas 2011-01-22 03:23:15 pgsql: Avoid treating WAL senders as normal backends.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-01-22 16:55:51 Re: REVIEW: EXPLAIN and nfiltered
Previous Message Jan Urbański 2011-01-22 15:12:00 Re: REVIEW: PL/Python table functions