| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Move test_fsync to /contrib. |
| Date: | 2011-01-22 17:08:46 |
| Message-ID: | 17681.1295716126@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Why does pg_test_fsync.c include postgres.h? Shouldn't it use postgres_fe.h?
I had tried that, actually, but it fails because the other include files
test_fsync needs are backend-specific. We may have to refactor those
include files so that the stuff test_fsync actually needs is includable
with less context required. I thought I'd wait on that project till we
had a full cycle from the buildfarm and could see what other portability
issues surface.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-01-22 17:12:06 | Re: [COMMITTERS] pgsql: Move test_fsync to /contrib. |
| Previous Message | Andrew Dunstan | 2011-01-22 16:38:23 | Re: [COMMITTERS] pgsql: Move test_fsync to /contrib. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2011-01-22 17:09:26 | Re: REVIEW: EXPLAIN and nfiltered |
| Previous Message | Tom Lane | 2011-01-22 16:55:51 | Re: REVIEW: EXPLAIN and nfiltered |