| From: | Mark Kirkwood <mark(dot)kirkwood(at)catalyst(dot)net(dot)nz> |
|---|---|
| To: | Merlin Moncure <mmoncure(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: How much do the hint bits help? |
| Date: | 2010-12-22 03:03:30 |
| Message-ID: | 4D116A82.9080108@catalyst.net.nz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 22/12/10 13:56, Merlin Moncure wrote:
> On Tue, Dec 21, 2010 at 7:45 PM, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> @Mark: apparently the cvs server is behind git and there are some
> recent changes to heapam.c that need more attention. I need to get
> git going on my box, but try changing this:
>
> if ((tuple->t_infomask& HEAP_XMIN_COMMITTED) ||
> (!(tuple->t_infomask& HEAP_XMIN_COMMITTED)&&
> !(tuple->t_infomask& HEAP_XMIN_INVALID)&&
> TransactionIdDidCommit(xmin)))
>
> to this:
>
> if (TransactionIdDidCommit(xmin))
>
> also, isn't the extra check vs HEAP_XMIN_COMMITTED redundant, and if
> you do have to look up clog, why not set the hint bit?
>
That gets it compiling.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-12-22 03:14:27 | Re: bug in SignalSomeChildren |
| Previous Message | Gurjeet Singh | 2010-12-22 02:30:14 | Re: strncmp->memcmp when we know the shorter length |