Re: shared_preload_libraries is ignored in single user mode

From: KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
To: PgSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: shared_preload_libraries is ignored in single user mode
Date: 2010-08-16 09:52:22
Message-ID: 4C690A56.4070500@ak.jp.nec.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Although nobody paid an attention, it seems to me a problem to be fixed.

The attached patch fixes the problem using a simple idea which adds
process_shared_preload_libraries() at PostgresMain() when we launched
it in single-user mode.

Thanks,

(2010/08/05 15:08), KaiGai Kohei wrote:
> I found out "shared_preload_libraries" setting is ignored when we launch
> postgres in single user mode.
>
> In this case, postgres command is launched with "--single" argument,
> then the main() directly invokes PostgresMain(); without going through
> PostmasterMain() which calls process_shared_preload_libraries().
>
> I think we should put the following code block on somewhere within
> PostgresMain() to fix up it.
>
> /*
> * If not under postmaster, shared preload libraries are not
> * loaded yet, so we try to load them here.
> */
> if (!IsUnderPostmaster)
> process_shared_preload_libraries();
>
> The reason why I want to use modules in single user mode is to assign
> initial security labels on database objects just after initdb.
> But, the GUC is ignored, we cannot invokes the routines in the module. :(
>
> Thanks,

--
KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>

Attachment Content-Type Size
pgsql-fix-preload-libraries.1.patch text/x-patch 750 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thom Brown 2010-08-16 10:03:39 Re: patch: psql variables tabcomplete
Previous Message Pavel Stehule 2010-08-16 09:52:19 patch: psql variables tabcomplete