Re: parallel restore vs. windows

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Andrew Chernow <ac(at)esilo(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: parallel restore vs. windows
Date: 2008-12-09 03:48:38
Message-ID: 493DEA96.3020603@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Chernow wrote:
>
>>> HANDLE h = (HANDLE)_beginthreadex(NULL, 0, thread_start, arg, 0, NULL);
>>
>> This didn't give me any more joy, unfortunately. But you're right, I
>> should be using it.
>>
>
> Are these threads sharing memory, intentionally or by mistake?

Things they write, and things they read but might not be stable, are not
supposed to be shared. If they are it's a mistake.

>
>>> if(h)
>>> CloseHandle(h);
>>
>> Umm, even if I wait on the handle using waitForMultipleObjects() ?
>>
>
> I was only trying to demonstrate that the value returned by
> _beginthread can be managed/closed just like any other win32 HANDLE.
>
> > I am terminating the thread by returning from the thread function. I
> > understand this is the recommended way.
>
> I didn't see a CloseHandle on ret_child anywhere. The HANDLE still
> exists after the thread exists, you still have to call CloseHandle.

OK. I'll put that in after handling the return.

thanks

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Chernow 2008-12-09 04:03:23 Re: parallel restore vs. windows
Previous Message Andrew Chernow 2008-12-09 03:32:26 Re: parallel restore vs. windows