| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Neil Conway <neilc(at)samurai(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Subject: | Re: tsearch in core patch, for inclusion |
| Date: | 2007-01-24 22:17:17 |
| Message-ID: | 45B7DAED.3010707@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Neil Conway wrote:
>> If people had a problem with integrating tsearch2 in core they should
>> have said so much earlier.
>>
>
> Peter, Tom and others raised essentially identical objections when this
> design was initially proposed. For example:
>
> http://archives.postgresql.org/pgsql-hackers/2006-11/msg00392.php
> http://archives.postgresql.org/pgsql-hackers/2006-11/msg00405.php
> http://archives.postgresql.org/pgsql-hackers/2006-11/msg00437.php
> http://archives.postgresql.org/pgsql-hackers/2006-11/msg00397.php
>
> Was a consensus reached in that thread? (I didn't see one, but perhaps
> I've overlooked a mail.)
>
>
IIRC Tom's main objection to the previous proposal was that it involved
large grammar changes, which I understand is not now proposed. The way I
read that thread was that there was no strenuous objection apart from
the grammar parts.
Certainly I think we can still argue about details, such as the
functional API.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-01-24 22:25:55 | Re: tsearch in core patch, for inclusion |
| Previous Message | Tom Lane | 2007-01-24 21:59:40 | Re: "tupdesc reference is not owned by resource owner Portal" |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-01-24 22:25:55 | Re: tsearch in core patch, for inclusion |
| Previous Message | Neil Conway | 2007-01-24 21:53:39 | Re: tsearch in core patch, for inclusion |