| From: | "Xavier Poinsard" <xpoinsard(at)free(dot)fr> |
|---|---|
| To: | Dave Cramer <pg(at)fastcrypt(dot)com> |
| Cc: | "pgsql-jdbc(at)postgresql(dot)org" <pgsql-jdbc(at)postgresql(dot)org> |
| Subject: | Re: Patch implementing escaped functions timestampadd and |
| Date: | 2006-03-22 16:18:55 |
| Message-ID: | 442178EF.7060904@free.fr |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-jdbc |
Dave Cramer a écrit :
> Xavier,
>
> Sorry I wasn't clear what I was trying to avoid is this
>
> you have 10 (didn't count) or so compares for SQL_TSI_*
>
> so what I am suggesting is that you compare for SQL_TSI_ and then
> compare for DAY, HOUR, etc in the sqltimestampdiff/sqltimestampadd
>
> You can determine quickly before creating the StringBuffer if you
> should even check for DAY,HOUR, etc.
>
> Plus the overhead of redundant checking of SQL_TSI_ is avoided.
>
> I realize these are nitpicky kinds of things, but I've recently become
> aware of certain java performance issues
>
The optimized version ...
| Attachment | Content-Type | Size |
|---|---|---|
| timestampfunc3.diff | text/plain | 9.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Cramer | 2006-03-23 14:52:29 | Re: Patch implementing escaped functions timestampadd and |
| Previous Message | Xavier Poinsard | 2006-03-22 14:55:00 | Re: Patch implementing escaped functions timestampadd and |