From: | "Xavier Poinsard" <xpoinsard(at)free(dot)fr> |
---|---|
To: | "pgsql-jdbc(at)postgresql(dot)org" <pgsql-jdbc(at)postgresql(dot)org> |
Subject: | Re: Patch implementing escaped functions timestampadd and |
Date: | 2006-03-22 14:55:00 |
Message-ID: | 44216544.7080309@free.fr |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-jdbc |
Dave Cramer a écrit :
> Xavier,
>
> Thanks, any chance we could get a context diff instead of a plain diff ?
I should be better.
>
> Also I looked at it briefly, can you change the if (SQL_TSI_DAY. ....
> checks to check for "SQL_TSI" , before you even create the stringbuffer
> in sqltimestampdiff, and sqltimestampadd
done.
>
> Ideally it would be good to verify all of the functions in the test .
That's a good point since I found several unexpected problems with the
backend implementation of extract which makes severals SQL_TSI
unavailable for timestampdiff :
select extract(month from interval '92 days');
date_part
-----------
0
(1 row)
test=> select extract(year from interval '900 days');
date_part
-----------
0
(1 row)
test=> select extract(quarter from interval '900 days');
date_part
-----------
1
(1 row)
>
> Dave
>
Attachment | Content-Type | Size |
---|---|---|
timestampfuncdoc2.diff | text/plain | 1.5 KB |
timestampfunc2.diff | text/plain | 9.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Xavier Poinsard | 2006-03-22 16:18:55 | Re: Patch implementing escaped functions timestampadd and |
Previous Message | Markus Schaber | 2006-03-22 14:36:33 | Re: pg_service.conf ? |