Re: initdb mkdir_p() doesn't work

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: initdb mkdir_p() doesn't work
Date: 2003-11-23 21:35:24
Message-ID: 3FC1281C.5090702@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:

>AFAICS mkdatadir() shouldn't consider subdir == NULL as a reason to
>fail rather than trying mkdir_p. Indeed, if anything the opposite:
>when subdir isn't NULL the immediately prior directory level should
>exist already.
>

Right. In fact, I can't see any good reason to call mkdir and then
mkdir_p at all. See my patch from this afternoon.

>
>I concur with Peter's gripe that a perror() or two wouldn't hurt here.
>

Sure. Of course, the reason I put this on my web site and asked for
eyeballs was to try to catch some of this sort of stuff before the
program went into the tree :-)

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2003-11-23 23:06:58 Re: Executable files in CVS
Previous Message Peter Eisentraut 2003-11-23 21:26:10 Executable files in CVS

Browse pgsql-patches by date

  From Date Subject
Next Message Peter Eisentraut 2003-11-23 21:43:24 Re: internationalization of initdb
Previous Message Tom Lane 2003-11-23 20:02:05 Re: initdb mkdir_p() doesn't work