| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Claudio Freire <klaussfreire(at)gmail(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Boszormenyi Zoltan <zb(at)cybertec(dot)at>, Hari Babu <haribabu(dot)kommi(at)huawei(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Hans-Jürgen Schönig <hs(at)cybertec(dot)at>, Ants Aasma <ants(at)cybertec(dot)at>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Amit kapila <amit(dot)kapila(at)huawei(dot)com> |
| Subject: | Re: unified vs context diffs (was Re: Strange Windows problem, lock_timeout test request) |
| Date: | 2013-02-25 14:25:50 |
| Message-ID: | 360.1361802350@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Stephen Frost <sfrost(at)snowman(dot)net> writes:
> * Robert Haas (robertmhaas(at)gmail(dot)com) wrote:
>> True, but I'm with Heikki: it's a pedantic and unhelpful guideline.
> Then let's change it, drop the preference, and update the documentation.
I think we should drop the hard requirement for context-format, and
instead say that it must not be plain (context-free) diff, since that
clearly *is* a hard requirement.
However, I liked the upthread suggestion (I think it was from Heikki)
that we recommend that submitters actually take a moment to think about
which format is more readable for their particular patch. Readability
is important not only to help people who just give the patch a quick
eyeball, but also to help the inevitable situations where hunks have
to be applied by hand because the underlying code has changed. The
less readable the patch, the more likely an error in doing that.
(And I trust we've all learned by now that git isn't so good at merging
that this isn't a problem.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2013-02-25 14:31:21 | Re: Why do we still perform a check for pre-sorted input within qsort variants? |
| Previous Message | Andres Freund | 2013-02-25 14:17:25 | Re: unified vs context diffs (was Re: Strange Windows problem, lock_timeout test request) |