Re: Proposed patch: remove hard-coded limit MAX_ALLOCATED_DESCS

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: cedric(at)2ndquadrant(dot)com
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Proposed patch: remove hard-coded limit MAX_ALLOCATED_DESCS
Date: 2013-06-08 21:27:16
Message-ID: 29785.1370726836@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

=?iso-8859-1?q?C=E9dric_Villemain?= <cedric(at)2ndquadrant(dot)com> writes:
> I'm not sure of expected value of "max_safe_fds". Your patch now initialize
> with 5 slots instead of 10, if max_safe_fds is large maybe it is better to
> double the size each time we need instead of jumping directly to the largest
> size ?

I don't see the point particularly. At the default value of
max_files_per_process (1000), the patch can allocate at most 500 array
elements, which on a 64-bit machine would probably be 16 bytes each
or 8KB total.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2013-06-08 21:41:33 Re: Optimising Foreign Key checks
Previous Message Kevin Grittner 2013-06-08 21:25:06 Re: Batch API for After Triggers