Re: Proposed patch: remove hard-coded limit MAX_ALLOCATED_DESCS

From: Cédric Villemain <cedric(at)2ndquadrant(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Proposed patch: remove hard-coded limit MAX_ALLOCATED_DESCS
Date: 2013-06-09 08:21:07
Message-ID: 201306091021.13437.cedric@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Le samedi 8 juin 2013 23:27:16, Tom Lane a écrit :
> =?iso-8859-1?q?C=E9dric_Villemain?= <cedric(at)2ndquadrant(dot)com> writes:
> > I'm not sure of expected value of "max_safe_fds". Your patch now
> > initialize with 5 slots instead of 10, if max_safe_fds is large maybe it
> > is better to double the size each time we need instead of jumping
> > directly to the largest size ?
>
> I don't see the point particularly. At the default value of
> max_files_per_process (1000), the patch can allocate at most 500 array
> elements, which on a 64-bit machine would probably be 16 bytes each
> or 8KB total.

The point was only if the original comment was still relevant. It seems it is
just not accurate anymore.
With patch I can union 492 csv tables instead of 32 with beta1.
--
Cédric Villemain +33 (0)6 20 30 22 52
http://2ndQuadrant.fr/
PostgreSQL: Support 24x7 - Développement, Expertise et Formation

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2013-06-09 08:50:08 Re: pgbench: introduce a new automatic variable 'client_number'
Previous Message Craig Ringer 2013-06-09 06:21:50 Re: Bad error message on valuntil