Re: array support patch phase 1 patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: array support patch phase 1 patch
Date: 2003-06-01 16:27:02
Message-ID: 27104.1054484822@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Joe Conway <mail(at)joeconway(dot)com> writes:
> Next question: should I roll the three array related patches floating
> around (phase2, phase3, polycoerce) into one big patch again? It's
> difficult for me to continue to make progress without doing that.

If it's easier at your end.

> + /* Last of the fast-paths: check for matching polymorphic arrays */
> + if (targettype == ANYARRAYOID)
> + if (get_element_type(srctype) != InvalidOid)
> + return true;

This doesn't seem quite right; won't the second test succeed for NAME
and other fixed-length-array types? You need to restrict it to varlena
arrays, I'd think.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Joe Conway 2003-06-01 16:54:05 Re: array support patch phase 1 patch
Previous Message Joe Conway 2003-06-01 16:19:58 Re: array support patch phase 1 patch