Re: [bug fix] pg_ctl always uses the same event source

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: MauMau <maumau307(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [bug fix] pg_ctl always uses the same event source
Date: 2014-01-22 03:49:36
Message-ID: 26587.1390362576@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> On Tue, Jan 21, 2014 at 6:57 PM, MauMau <maumau307(at)gmail(dot)com> wrote:
>> To follow this, we have the line as:
>>
>> #event_source = 'PostgreSQL 9.4'
>>
>> But this requires us to change this line for each major release. That's a
>> maintenance headache.

> What I had in mind was to change it during initdb, we are already doing it
> for some other parameter (unix_socket_directories),

What happens when somebody copies their postgresql.conf from an older
version? That's hardly uncommon, even though it might be considered bad
practice. I don't think it's a good idea to try to insert a version
identifier this way.

But ... what's the point of including the PG version in this string
anyhow? If you're trying to make the string unique across different
installations on the same machine, it's surely insufficient, and if
that's not the point then what is?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-01-22 03:53:27 Re: PoC: Duplicate Tuple Elidation during External Sort for DISTINCT
Previous Message Tom Lane 2014-01-22 03:42:29 Re: Add %z support to elog/ereport?