Re: gcc 4.6 and hot standby

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alex Hunsaker <badalex(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Mark Kirkwood <mark(dot)kirkwood(at)catalyst(dot)net(dot)nz>
Subject: Re: gcc 4.6 and hot standby
Date: 2011-06-10 20:24:11
Message-ID: 25534.1307737451@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alex Hunsaker <badalex(at)gmail(dot)com> writes:
> On Fri, Jun 10, 2011 at 12:38, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I think we need a workaround.

My second idea about moving the test up doesn't work, because we can't
know the page header size until after we've read the page. But I've
verified that the attached patch does make the problem go away on my
F15 box.

> Hrm, Couldn't we change all the references to tmpRecPtr to use RecPtr
> instead? (Except of course where we assign RecPtr = &tmpRecPtr); I
> think that would make the code look a lot less confused. Something
> like the attached?

Yeah, we could do that too; slightly modified version of your change
included in the attached.

regards, tom lane

Attachment Content-Type Size
dodge-gcc-bug-2.patch text/x-patch 3.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alex Hunsaker 2011-06-10 20:51:42 Re: gcc 4.6 and hot standby
Previous Message Alex Hunsaker 2011-06-10 20:00:26 Re: gcc 4.6 and hot standby