Re: make --enable-depend the default

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: make --enable-depend the default
Date: 2013-08-01 12:34:51
Message-ID: 23884.1375360491@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> People, including me, every now and then forget to pass --enable-depend
> to configure (when not using my own environment). Which then leads to
> strange errors that cost time to track down...

> Thus I'd like to enable dependency tracking by default. Given todays
> computing powers there doesn't seem to be much reason not to do so.

> Any arguments against?

Yes: it's a waste of resources for one-shot builds, which is what most
people not reading this list do (and by asking here, you're biasing
your poll).

Personally I always do "make clean", if not "make distclean", after a git
pull. If you're using ccache it's incredibly cheap to just rebuild the
whole tree every time, and I trust the results a lot more than I do
--enable-depend.

[postgres(at)sss1 pgsql]$ time make -s clean

real 0m1.613s
user 0m0.994s
sys 0m0.254s
[postgres(at)sss1 pgsql]$ time make -s -j8
In file included from gram.y:13635:
scan.c: In function 'yy_try_NUL_trans':
scan.c:10167: warning: unused variable 'yyg'
All of PostgreSQL successfully made. Ready to install.

real 0m2.483s
user 0m6.693s
sys 0m2.123s

(make installcheck-parallel takes 13.6 seconds on this machine...)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2013-08-01 13:08:29 Re: make --enable-depend the default
Previous Message Dimitri Fontaine 2013-08-01 12:12:27 Re: Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])