Re: pg_xlogdump compiler warning

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_xlogdump compiler warning
Date: 2013-02-26 20:52:01
Message-ID: 21281.1361911921@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2013-02-25 18:15:48 -0500, Peter Eisentraut wrote:
>> compat.c: In function timestamptz_to_str:
>> compat.c:56:9: error: passing argument 1 of localtime from incompatible pointer type [-Werror]
>> In file included from compat.c:21:0:
>> /usr/include/time.h:237:19: note: expected const time_t * but argument is of type pg_time_t *

> 32bit I guess?

Yeah, I see the same on a 32-bit machine.

> A simple cast should do for now. Patch attached.

Pushed along with some other, more cosmetic cleanups.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2013-02-26 21:09:30 Re: FILTER for aggregates [was Re: Department of Redundancy Department: makeNode(FuncCall) division]
Previous Message Tom Lane 2013-02-26 20:28:27 Re: PGXS contrib builds broken?