Re: pg_xlogdump compiler warning

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_xlogdump compiler warning
Date: 2013-02-26 12:35:41
Message-ID: 20130226123541.GE4405@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2013-02-25 18:15:48 -0500, Peter Eisentraut wrote:
> compat.c: In function ‘timestamptz_to_str’:
> compat.c:56:9: error: passing argument 1 of ‘localtime’ from incompatible pointer type [-Werror]
> In file included from compat.c:21:0:
> /usr/include/time.h:237:19: note: expected ‘const time_t *’ but argument is of type ‘pg_time_t *’
>
> gcc 4.7.2

32bit I guess?

A simple cast should do for now. Patch attached.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
correct-cast-to-time_t.patch text/x-patch 583 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2013-02-26 12:57:46 Re: PGXS contrib builds broken?
Previous Message Andres Freund 2013-02-26 12:08:54 Re: [RFC] Extend namespace of valid guc names