Re: pg_restore fails with a custom backup file

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Yoshiyuki Asaba <y-asaba(at)sraoss(dot)co(dot)jp>, ZeugswetterA(at)spardat(dot)at, andrew(at)dunslane(dot)net, z-saito(at)guitar(dot)ocn(dot)ne(dot)jp, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_restore fails with a custom backup file
Date: 2007-02-17 18:28:22
Message-ID: 20604.1171736902@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> I'd also like a comment from at least one other "patch reviewer" that
> the methods used are good.

It looks reasonable as far as it goes. One thought is that pg_dump
really should have noticed that it was writing a broken archive.
On machines where off_t is 32 bits, can't we detect the overflow
situation?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Fuhr 2007-02-17 18:31:19 Re: [ANNOUNCE] Advisory on possibly insecure security definer functions
Previous Message Tom Lane 2007-02-17 18:23:38 Re: Re: [GENERAL] [ANNOUNCE] Advisory on possibly insecure security definer functions