Re: Minor binary-search int overflow in timezone code

From: Christoph Berg <cb(at)df7cb(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Minor binary-search int overflow in timezone code
Date: 2014-12-15 19:39:03
Message-ID: 20141215193903.GA14863@msg.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Re: Tom Lane 2014-12-15 <21813(dot)1418655100(at)sss(dot)pgh(dot)pa(dot)us>
> This is totally silly. The timecnt couldn't be anywhere near INT_MAX (in
> fact, it is not allowed to exceed TZ_MAX_TIMES, which is currently just
> 1200). And there are bunches of other instances of similar code in PG;
> shall we put equally wishy-washy comments on them all?

Well, if it's not interesting, let's just forget it. Sorry.

Christoph
--
cb(at)df7cb(dot)de | http://www.df7cb.de/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2014-12-15 19:52:35 Re: Commitfest problems
Previous Message Robert Haas 2014-12-15 19:27:14 Re: Commitfest problems